| 1 |
From: Arend van Spriel <arend.vanspriel-dY08KVG/lbpWk0Htik3J/w@public.gmane.org> |
| 2 |
Subject: [PATCH V2] wifi: brcmfmac: fix regression for Broadcom PCIe wifi devices |
| 3 |
Date: Wed, 11 Jan 2023 12:24:19 +0100 |
| 4 |
|
| 5 |
A sanity check was introduced considering maximum flowrings above |
| 6 |
256 as insane and effectively aborting the device probe. This |
| 7 |
resulted in regression for number of users as the value turns out |
| 8 |
to be sane after all. |
| 9 |
|
| 10 |
Fixes: 2aca4f3734bd ("brcmfmac: return error when getting invalid max_flowrings from dongle") |
| 11 |
Reported-by: chainofflowers <chainofflowers-VwIFZPTo/vqsTnJN9+BGXg@public.gmane.org> |
| 12 |
Link: https://lore.kernel.org/all/4781984.GXAFRqVoOG@luna/ |
| 13 |
Reported-by: Christian Marillat <marillat-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org> |
| 14 |
Link: https://bugzilla.kernel.org/show_bug.cgi?id=216894 |
| 15 |
Signed-off-by: Arend van Spriel <arend.vanspriel-dY08KVG/lbpWk0Htik3J/w@public.gmane.org> |
| 16 |
--- |
| 17 |
drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 2 +- |
| 18 |
1 file changed, 1 insertion(+), 1 deletion(-) |
| 19 |
|
| 20 |
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c |
| 21 |
index ae57a9a3ab05..b67f6d0810b6 100644 |
| 22 |
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c |
| 23 |
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c |
| 24 |
@@ -1228,7 +1228,7 @@ static int brcmf_pcie_init_ringbuffers(struct brcmf_pciedev_info *devinfo) |
| 25 |
BRCMF_NROF_H2D_COMMON_MSGRINGS; |
| 26 |
max_completionrings = BRCMF_NROF_D2H_COMMON_MSGRINGS; |
| 27 |
} |
| 28 |
- if (max_flowrings > 256) { |
| 29 |
+ if (max_flowrings > 512) { |
| 30 |
brcmf_err(bus, "invalid max_flowrings(%d)\n", max_flowrings); |
| 31 |
return -EIO; |
| 32 |
} |
| 33 |
-- |
| 34 |
2.32.0 |
Parent Directory
| 
Revision Log