1 |
From 8bcd338454f860df2c8ea64f605ae183e338755c Mon Sep 17 00:00:00 2001 |
2 |
From: Ben Peddell <klightspeed@killerwolves.net> |
3 |
Date: Mon, 8 Oct 2018 20:41:13 +0800 |
4 |
Subject: [PATCH 023/145] bcache: Populate writeback_rate_minimum attribute |
5 |
|
6 |
[ Upstream commit 7567c2a2ad9e80a2ce977eef535e64b61899633e ] |
7 |
|
8 |
Forgot to include the maintainers with my first email. |
9 |
|
10 |
Somewhere between Michael Lyle's original |
11 |
"bcache: PI controller for writeback rate V2" patch dated 07 Sep 2017 |
12 |
and 1d316e6 bcache: implement PI controller for writeback rate, |
13 |
the mapping of the writeback_rate_minimum attribute was dropped. |
14 |
|
15 |
Re-add the missing sysfs writeback_rate_minimum attribute mapping to |
16 |
"allow the user to specify a minimum rate at which dirty blocks are |
17 |
retired." |
18 |
|
19 |
Fixes: 1d316e6 ("bcache: implement PI controller for writeback rate") |
20 |
Signed-off-by: Ben Peddell <klightspeed@killerwolves.net> |
21 |
Signed-off-by: Coly Li <colyli@suse.de> |
22 |
Signed-off-by: Jens Axboe <axboe@kernel.dk> |
23 |
Signed-off-by: Sasha Levin <sashal@kernel.org> |
24 |
--- |
25 |
drivers/md/bcache/sysfs.c | 2 ++ |
26 |
1 file changed, 2 insertions(+) |
27 |
|
28 |
diff --git a/drivers/md/bcache/sysfs.c b/drivers/md/bcache/sysfs.c |
29 |
index 150cf4f4cf74..26f035a0c5b9 100644 |
30 |
--- a/drivers/md/bcache/sysfs.c |
31 |
+++ b/drivers/md/bcache/sysfs.c |
32 |
@@ -285,6 +285,7 @@ STORE(__cached_dev) |
33 |
1, WRITEBACK_RATE_UPDATE_SECS_MAX); |
34 |
d_strtoul(writeback_rate_i_term_inverse); |
35 |
d_strtoul_nonzero(writeback_rate_p_term_inverse); |
36 |
+ d_strtoul_nonzero(writeback_rate_minimum); |
37 |
|
38 |
sysfs_strtoul_clamp(io_error_limit, dc->error_limit, 0, INT_MAX); |
39 |
|
40 |
@@ -412,6 +413,7 @@ static struct attribute *bch_cached_dev_files[] = { |
41 |
&sysfs_writeback_rate_update_seconds, |
42 |
&sysfs_writeback_rate_i_term_inverse, |
43 |
&sysfs_writeback_rate_p_term_inverse, |
44 |
+ &sysfs_writeback_rate_minimum, |
45 |
&sysfs_writeback_rate_debug, |
46 |
&sysfs_errors, |
47 |
&sysfs_io_error_limit, |
48 |
-- |
49 |
2.19.1 |
50 |
|