| 1 |
From d4055d5496de3165b7e3649aac768fafd8bcd7c1 Mon Sep 17 00:00:00 2001 |
| 2 |
From: Arnaldo Carvalho de Melo <acme@redhat.com> |
| 3 |
Date: Wed, 5 Sep 2018 10:47:56 -0300 |
| 4 |
Subject: [PATCH 065/145] perf tests: Fix record+probe_libc_inet_pton.sh |
| 5 |
without ping's debuginfo |
| 6 |
|
| 7 |
[ Upstream commit 1632936480a53d85ef3012cd9f290e247251cbb9 ] |
| 8 |
|
| 9 |
When we don't have the iputils-debuginfo package installed, i.e. when we |
| 10 |
don't have the DWARF information needed to resolve ping's samples, we |
| 11 |
end up failing this 'perf test' entry: |
| 12 |
|
| 13 |
# perf test ping |
| 14 |
62: probe libc's inet_pton & backtrace it with ping : Ok |
| 15 |
# rpm -e iputils-debuginfo |
| 16 |
# perf test ping |
| 17 |
62: probe libc's inet_pton & backtrace it with ping : FAILED! |
| 18 |
# |
| 19 |
|
| 20 |
Fix it to accept "[unknown]" where the symbol + offset, when resolved, |
| 21 |
is expected. |
| 22 |
|
| 23 |
I think this will fail in the other arches as well, but since I can't |
| 24 |
test now, I'm leaving s390x and ppc cases as-is. |
| 25 |
|
| 26 |
Cc: Adrian Hunter <adrian.hunter@intel.com> |
| 27 |
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> |
| 28 |
Cc: David Ahern <dsahern@gmail.com> |
| 29 |
Cc: Hendrik Brueckner <brueckner@linux.vnet.ibm.com> |
| 30 |
Cc: Jiri Olsa <jolsa@kernel.org> |
| 31 |
Cc: Kim Phillips <kim.phillips@arm.com> |
| 32 |
Cc: Michael Petlan <mpetlan@redhat.com> |
| 33 |
Cc: Namhyung Kim <namhyung@kernel.org> |
| 34 |
Cc: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com> |
| 35 |
Cc: Peter Zijlstra <peterz@infradead.org> |
| 36 |
Cc: Ravi Bangoria <ravi.bangoria@linux.ibm.com> |
| 37 |
Cc: Sandipan Das <sandipan@linux.vnet.ibm.com> |
| 38 |
Cc: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com> |
| 39 |
Cc: Thomas Richter <tmricht@linux.vnet.ibm.com> |
| 40 |
Cc: Wang Nan <wangnan0@huawei.com> |
| 41 |
Fixes: 7903a7086723 ("perf script: Show symbol offsets by default") |
| 42 |
Link: https://lkml.kernel.org/n/tip-hnizqwqrs03vcq1b74yao0f6@git.kernel.org |
| 43 |
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> |
| 44 |
Signed-off-by: Sasha Levin <sashal@kernel.org> |
| 45 |
--- |
| 46 |
tools/perf/tests/shell/record+probe_libc_inet_pton.sh | 2 +- |
| 47 |
1 file changed, 1 insertion(+), 1 deletion(-) |
| 48 |
|
| 49 |
diff --git a/tools/perf/tests/shell/record+probe_libc_inet_pton.sh b/tools/perf/tests/shell/record+probe_libc_inet_pton.sh |
| 50 |
index 3013ac8f83d0..cab7b0aea6ea 100755 |
| 51 |
--- a/tools/perf/tests/shell/record+probe_libc_inet_pton.sh |
| 52 |
+++ b/tools/perf/tests/shell/record+probe_libc_inet_pton.sh |
| 53 |
@@ -48,7 +48,7 @@ trace_libc_inet_pton_backtrace() { |
| 54 |
*) |
| 55 |
eventattr='max-stack=3' |
| 56 |
echo "getaddrinfo\+0x[[:xdigit:]]+[[:space:]]\($libc\)$" >> $expected |
| 57 |
- echo ".*\+0x[[:xdigit:]]+[[:space:]]\(.*/bin/ping.*\)$" >> $expected |
| 58 |
+ echo ".*(\+0x[[:xdigit:]]+|\[unknown\])[[:space:]]\(.*/bin/ping.*\)$" >> $expected |
| 59 |
;; |
| 60 |
esac |
| 61 |
|
| 62 |
-- |
| 63 |
2.19.1 |
| 64 |
|
Parent Directory
| 
Revision Log