1 |
From 31e203e09f036f48e7c567c2d32df0196bbd303f Mon Sep 17 00:00:00 2001 |
2 |
From: Daejun Park <daejun7.park@samsung.com> |
3 |
Date: Wed, 30 Dec 2020 18:48:51 +0900 |
4 |
Subject: [PATCH] ext4: fix wrong list_splice in ext4_fc_cleanup |
5 |
|
6 |
After full/fast commit, entries in staging queue are promoted to main |
7 |
queue. In ext4_fs_cleanup function, it splice to staging queue to |
8 |
staging queue. |
9 |
|
10 |
Fixes: aa75f4d3daaeb ("ext4: main fast-commit commit path") |
11 |
Signed-off-by: Daejun Park <daejun7.park@samsung.com> |
12 |
Reviewed-by: Harshad Shirwadkar <harshadshirwadkar@gmail.com> |
13 |
Link: https://lore.kernel.org/r/20201230094851epcms2p6eeead8cc984379b37b2efd21af90fd1a@epcms2p6 |
14 |
Signed-off-by: Theodore Ts'o <tytso@mit.edu> |
15 |
Cc: stable@kernel.org |
16 |
--- |
17 |
fs/ext4/fast_commit.c | 2 +- |
18 |
1 file changed, 1 insertion(+), 1 deletion(-) |
19 |
|
20 |
diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c |
21 |
index 6b5489273c85..ec5316fbcd1d 100644 |
22 |
--- a/fs/ext4/fast_commit.c |
23 |
+++ b/fs/ext4/fast_commit.c |
24 |
@@ -1268,7 +1268,7 @@ static void ext4_fc_cleanup(journal_t *journal, int full) |
25 |
list_splice_init(&sbi->s_fc_dentry_q[FC_Q_STAGING], |
26 |
&sbi->s_fc_dentry_q[FC_Q_MAIN]); |
27 |
list_splice_init(&sbi->s_fc_q[FC_Q_STAGING], |
28 |
- &sbi->s_fc_q[FC_Q_STAGING]); |
29 |
+ &sbi->s_fc_q[FC_Q_MAIN]); |
30 |
|
31 |
ext4_clear_mount_flag(sb, EXT4_MF_FC_COMMITTING); |
32 |
ext4_clear_mount_flag(sb, EXT4_MF_FC_INELIGIBLE); |
33 |
-- |
34 |
2.30.0 |
35 |
|