| 1 |
From 72a6f5d1a3acdfc383b1968c4cabaf1deae0a09e Mon Sep 17 00:00:00 2001 |
| 2 |
From: Ian Romanick <ian.d.romanick@intel.com> |
| 3 |
Date: Mon, 17 Dec 2018 18:48:17 -0800 |
| 4 |
Subject: [PATCH 27/78] Revert "nir/lower_indirect: Bail early if modes == 0" |
| 5 |
|
| 6 |
"There's no point in walking the program if we're never going to |
| 7 |
actually lower anything." |
| 8 |
|
| 9 |
Except we might lower compacted local arrays. In that case, modes will |
| 10 |
be 0, but there is still lowering to be done. |
| 11 |
|
| 12 |
This reverts commit 7f75cf2a9408b9af562e033ef6c1d1fd15141421. |
| 13 |
|
| 14 |
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109081 |
| 15 |
Suggested-by: Kenneth Graunke <kenneth@whitecape.org> |
| 16 |
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net> |
| 17 |
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> |
| 18 |
Tested-by: Clayton Craft <clayton.a.craft@intel.com> |
| 19 |
Cc: Kenneth Graunke <kenneth@whitecape.org> |
| 20 |
(cherry picked from commit 29e4b949b45b468c366b9865298391c89ba6642c) |
| 21 |
--- |
| 22 |
src/compiler/nir/nir_lower_indirect_derefs.c | 3 --- |
| 23 |
1 file changed, 3 deletions(-) |
| 24 |
|
| 25 |
diff --git a/src/compiler/nir/nir_lower_indirect_derefs.c b/src/compiler/nir/nir_lower_indirect_derefs.c |
| 26 |
index 897a062087..40b90e6a31 100644 |
| 27 |
--- a/src/compiler/nir/nir_lower_indirect_derefs.c |
| 28 |
+++ b/src/compiler/nir/nir_lower_indirect_derefs.c |
| 29 |
@@ -205,9 +205,6 @@ nir_lower_indirect_derefs(nir_shader *shader, nir_variable_mode modes) |
| 30 |
{ |
| 31 |
bool progress = false; |
| 32 |
|
| 33 |
- if (modes == 0) |
| 34 |
- return false; |
| 35 |
- |
| 36 |
nir_foreach_function(function, shader) { |
| 37 |
if (function->impl) |
| 38 |
progress = lower_indirects_impl(function->impl, modes) || progress; |
| 39 |
-- |
| 40 |
2.20.1 |
| 41 |
|
Parent Directory
| 
Revision Log