| 1 |
From 67facd5d9868474702cb8a3acf8be468e65df92b Mon Sep 17 00:00:00 2001 |
| 2 |
From: Anssi Hannula <anssi@xbmc.org> |
| 3 |
Date: Sat, 3 Mar 2012 21:15:46 +0200 |
| 4 |
Subject: [PATCH] fixed: undefined symbols in MythTV PVR client |
| 5 |
|
| 6 |
The MythTV PVR client uses functionality from libmythxml.a but does not |
| 7 |
link it in. Additionally, it fails to implement several PVR channel |
| 8 |
functions, and has a wrong name for GetChannelsAmount(). Also, it is |
| 9 |
linked against libdl which it doesn't use. |
| 10 |
|
| 11 |
To fix the undefined symbols, make the client link against libmythxml.a, |
| 12 |
add stubs for the missing functions, and change GetNumChannels() to |
| 13 |
GetChannelsAmount(). Also drop unused -ldl from the linking command |
| 14 |
line. |
| 15 |
--- |
| 16 |
xbmc/pvrclients/mythtv/Makefile.in | 2 +- |
| 17 |
xbmc/pvrclients/mythtv/client.cpp | 17 ++++++++++++++++- |
| 18 |
2 files changed, 17 insertions(+), 2 deletions(-) |
| 19 |
|
| 20 |
diff --git a/xbmc/pvrclients/mythtv/Makefile.in b/xbmc/pvrclients/mythtv/Makefile.in |
| 21 |
index 4de3ac5..5d02ff2 100644 |
| 22 |
--- a/xbmc/pvrclients/mythtv/Makefile.in |
| 23 |
+++ b/xbmc/pvrclients/mythtv/Makefile.in |
| 24 |
@@ -5,7 +5,7 @@ |
| 25 |
# how to reach the author. |
| 26 |
# |
| 27 |
|
| 28 |
-LIBS = -ldl |
| 29 |
+LIBS = libmythxml/libmythxml.a |
| 30 |
LIBDIR = @abs_top_srcdir@/addons/pvr.mythtv |
| 31 |
LIB = @abs_top_srcdir@/addons/pvr.mythtv/XBMC_Mythtv.pvr |
| 32 |
|
| 33 |
diff --git a/xbmc/pvrclients/mythtv/client.cpp b/xbmc/pvrclients/mythtv/client.cpp |
| 34 |
index 1b98a69..95f7c32 100644 |
| 35 |
--- a/xbmc/pvrclients/mythtv/client.cpp |
| 36 |
+++ b/xbmc/pvrclients/mythtv/client.cpp |
| 37 |
@@ -292,7 +292,7 @@ PVR_ERROR GetEPGForChannel(PVR_HANDLE handle, const PVR_CHANNEL &channel, time_t |
| 38 |
/*******************************************/ |
| 39 |
/** PVR Channel Functions **/ |
| 40 |
|
| 41 |
-int GetNumChannels() |
| 42 |
+int GetChannelsAmount(void) |
| 43 |
{ |
| 44 |
if (MythXmlApi == NULL) |
| 45 |
return PVR_ERROR_SERVER_ERROR; |
| 46 |
@@ -308,6 +308,21 @@ PVR_ERROR GetChannels(PVR_HANDLE handle, bool bRadio) |
| 47 |
return MythXmlApi->requestChannelList(handle, bRadio); |
| 48 |
} |
| 49 |
|
| 50 |
+int GetChannelGroupsAmount(void) |
| 51 |
+{ |
| 52 |
+ return 0; |
| 53 |
+} |
| 54 |
+ |
| 55 |
+PVR_ERROR GetChannelGroups(PVR_HANDLE handle, bool bRadio) |
| 56 |
+{ |
| 57 |
+ return PVR_ERROR_NOT_IMPLEMENTED; |
| 58 |
+} |
| 59 |
+ |
| 60 |
+PVR_ERROR GetChannelGroupMembers(PVR_HANDLE handle, const PVR_CHANNEL_GROUP &group) |
| 61 |
+{ |
| 62 |
+ return PVR_ERROR_NOT_IMPLEMENTED; |
| 63 |
+} |
| 64 |
+ |
| 65 |
PVR_ERROR DeleteChannel(const PVR_CHANNEL &channel) |
| 66 |
{ |
| 67 |
return PVR_ERROR_NOT_IMPLEMENTED; |
| 68 |
-- |
| 69 |
1.7.7.2 |
| 70 |
|
Parent Directory
| 
Revision Log