1 |
From 89b99a414e38b12df13a097ada1d6f2f72039408 Mon Sep 17 00:00:00 2001 |
2 |
Message-Id: <89b99a414e38b12df13a097ada1d6f2f72039408.1351714946.git.erack@redhat.com> |
3 |
From: Noel Power <noel.power@novell.com> |
4 |
Date: Tue, 2 Oct 2012 18:04:55 +0100 |
5 |
Subject: [PATCH] rhbz#854451 fdo#46278 - misc comment import/export fixes |
6 |
MIME-Version: 1.0 |
7 |
Content-Type: multipart/mixed; boundary="------------erAck-patch-parts" |
8 |
|
9 |
This is a multi-part message in MIME format. |
10 |
--------------erAck-patch-parts |
11 |
Content-Type: text/plain; charset=UTF-8; format=fixed |
12 |
Content-Transfer-Encoding: 8bit |
13 |
|
14 |
|
15 |
detect whether note/comment is shown on import |
16 |
export state of note ( shown/hidden ) |
17 |
|
18 |
parts of Change-Id: I59b446175217479ce7960287aa540df8c6b2b1e |
19 |
Signed-off-by: Michael Meeks <michael.meeks@suse.com> |
20 |
(cherry picked from commit ebc8ebaff65ac02d410c8e9e39c2776131955cd7) |
21 |
|
22 |
Conflicts: |
23 |
|
24 |
sc/source/filter/oox/commentsbuffer.cxx |
25 |
|
26 |
Change of sc/source/filter/oox/commentsbuffer.cxx merged to |
27 |
oox/source/xls/commentsbuffer.cxx instead. |
28 |
|
29 |
Change-Id: Ief52da32fcb43d6c066f84205cf2d1cfee6ed126 |
30 |
Signed-off-by: Eike Rathke <erack@redhat.com> |
31 |
--- |
32 |
oox/source/export/vmlexport.cxx | 3 ++- |
33 |
oox/source/xls/commentsbuffer.cxx | 3 +-- |
34 |
sc/source/filter/xcl97/xcl97rec.cxx | 2 +- |
35 |
3 files changed, 4 insertions(+), 4 deletions(-) |
36 |
|
37 |
|
38 |
--------------erAck-patch-parts |
39 |
Content-Type: text/x-patch; name="0001-rhbz-854451-fdo-46278-misc-comment-import-export-fix.patch" |
40 |
Content-Transfer-Encoding: 8bit |
41 |
Content-Disposition: attachment; filename="0001-rhbz-854451-fdo-46278-misc-comment-import-export-fix.patch" |
42 |
|
43 |
diff --git a/oox/source/export/vmlexport.cxx b/oox/source/export/vmlexport.cxx |
44 |
index 554d49f..0b4b470 100644 |
45 |
--- a/oox/source/export/vmlexport.cxx |
46 |
+++ b/oox/source/export/vmlexport.cxx |
47 |
@@ -662,7 +662,8 @@ void VMLExport::Commit( EscherPropertyContainer& rProps, const Rectangle& rRect |
48 |
break; |
49 |
|
50 |
case ESCHER_Prop_fHidden: |
51 |
- m_pShapeStyle->append( ";visibility:hidden" ); |
52 |
+ if ( !it->nPropValue ) |
53 |
+ m_pShapeStyle->append( ";visibility:hidden" ); |
54 |
break; |
55 |
default: |
56 |
#if OSL_DEBUG_LEVEL > 0 |
57 |
diff --git a/oox/source/xls/commentsbuffer.cxx b/oox/source/xls/commentsbuffer.cxx |
58 |
index 55dd28b..067cafe 100644 |
59 |
--- a/oox/source/xls/commentsbuffer.cxx |
60 |
+++ b/oox/source/xls/commentsbuffer.cxx |
61 |
@@ -268,8 +268,7 @@ void Comment::finalizeImport() |
62 |
// position and formatting |
63 |
pNoteShape->convertFormatting( xAnnoShape ); |
64 |
// visibility |
65 |
- const ::oox::vml::ClientData* pClientData = pNoteShape->getClientData(); |
66 |
- xAnno->setIsVisible( pClientData && pClientData->mbVisible ); |
67 |
+ bVisible = pNoteShape->getTypeModel().mbVisible; |
68 |
} |
69 |
} |
70 |
break; |
71 |
diff --git a/sc/source/filter/xcl97/xcl97rec.cxx b/sc/source/filter/xcl97/xcl97rec.cxx |
72 |
index 56f30fe..106d63e 100644 |
73 |
--- a/sc/source/filter/xcl97/xcl97rec.cxx |
74 |
+++ b/sc/source/filter/xcl97/xcl97rec.cxx |
75 |
@@ -566,7 +566,7 @@ VmlCommentExporter::VmlCommentExporter( sax_fastparser::FSHelperPtr p, ScAddress |
76 |
void VmlCommentExporter::Commit( EscherPropertyContainer& rProps, const Rectangle& rRect ) |
77 |
{ |
78 |
lcl_FillProps( rProps, mpCaption, mbVisible ); |
79 |
- rProps.AddOpt( ESCHER_Prop_fHidden, 1 ); // bool field |
80 |
+ rProps.AddOpt( ESCHER_Prop_fHidden, mbVisible ); // bool field |
81 |
|
82 |
VMLExport::Commit( rProps, rRect ); |
83 |
} |
84 |
|
85 |
--------------erAck-patch-parts-- |
86 |
|
87 |
|